This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Respect project-level GMS version on Android #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steelbrain
changed the title
|
@isnifer can this be merged/pushed? |
|
@steelbrain HI! Could you please update an example app like here — https://github.com/tipsi/tipsi-stripe/pull/297/files |
|
Thanks @isnifer I've added the new parameters to the example app, I've used the default values in the SDK to populate them in the example as well. |
|
@cybergrind also, please, set a new version :) |
|
@steelbrain thank you for contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-coding a GCM version makes it impossible to compile on Android project that uses different GCM or firebase version.
This seems to be a new trend in Android dependencies to solve dependency conflict for GCM and Firebase. See react-native-google-places and react-native-push-notification for example
This change is non-breaking because it still uses the older versions as fallback. No project could've defined a different version and used tipsi-stripe (as the compilation would've failed anyway because of a dep conflict).