Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to copy initialization code from examples #21

Merged
merged 2 commits into from Jun 16, 2018

Conversation

kostasx
Copy link
Contributor

@kostasx kostasx commented Jun 13, 2018

Adding the ability to copy the necessary initialization code to the clipboard from the examples for easy and quick setup.

Example

@tipsy
Copy link
Owner

tipsy commented Jun 14, 2018

Thanks @kostasx, that's pretty neat.

Could you make it a bit less "intrusive" ? Instead of having the big copy icon in the middle, just write a text (Copy config) in the top right corner, and remove the code-popup when the code is copied? Just have a smaller popup which says something like "Config copied to clipboard`? And don't display it on mobile?

@tipsy
Copy link
Owner

tipsy commented Jun 14, 2018

You could also use https://clipboardjs.com to make things simpler.

@kostasx
Copy link
Contributor Author

kostasx commented Jun 14, 2018

Thanks for the feedback @tipsy. I will review your suggestions and make the necessary changes, probably tonight.

…g button and notification as less obstrusive as possible.
@kostasx
Copy link
Contributor Author

kostasx commented Jun 16, 2018

Updated.

@tipsy
Copy link
Owner

tipsy commented Jun 16, 2018

Looks great, thank you!

@tipsy tipsy merged commit c9c3961 into tipsy:master Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants