Fix regression defusedxml.ElementTree.ParseError

The ``defusedxml.ElementTree.ParseError`` exception is now the same class object
as ``xml.etree.ElementTree.ParseError`` again. The regression was
introduced by new patching code as part of PR #60.

See: #60
Fixes: #63
Signed-off-by: Christian Heimes <christian@python.org>

CHANGES.txt

@@ -6,6 +6,9 @@ defusedxml 0.8.0.dev1
 
 - Drop support for Python 2.7, 3.4, and 3.5.
 - Add ``defusedxml.ElementTree.fromstringlist()``
+- Fix regression ``defusedxml.ElementTree.ParseError`` (#63)
+  The ``ParseError`` exception is now the same class object as
+  ``xml.etree.ElementTree.ParseError`` again.
 
 
 defusedxml 0.7.0

README.md

@@ -720,6 +720,9 @@ See <https://www.python.org/psf/license> for licensing details.
 
   - Drop support for Python 2.7, 3.4, and 3.5.
   - Add `defusedxml.ElementTree.fromstringlist()`
+  - Fix regression `defusedxml.ElementTree.ParseError` (\#63) The
+    `ParseError` exception is now the same class object as
+    `xml.etree.ElementTree.ParseError` again.
 
 ## defusedxml 0.7.0
 

defusedxml/ElementTree.py

@@ -9,6 +9,7 @@
 
 import sys
 import warnings
+from xml.etree.ElementTree import ParseError
 from xml.etree.ElementTree import TreeBuilder as _TreeBuilder
 from xml.etree.ElementTree import parse as _parse
 from xml.etree.ElementTree import tostring
@@ -51,12 +52,13 @@ def _get_py3_cls():
 
     _XMLParser = pure_pymod.XMLParser
     _iterparse = pure_pymod.iterparse
-    ParseError = pure_pymod.ParseError
+    # patch pure module to use ParseError from C extension
+    pure_pymod.ParseError = ParseError
 
-    return _XMLParser, _iterparse, ParseError
+    return _XMLParser, _iterparse
 
 
-_XMLParser, _iterparse, ParseError = _get_py3_cls()
+_XMLParser, _iterparse = _get_py3_cls()
 
 _sentinel = object()
 

defusedxml/cElementTree.py

@@ -19,6 +19,7 @@
     parse,
     tostring,
     DefusedXMLParser,
+    ParseError,
 )
 
 __origin__ = "xml.etree.cElementTree"
@@ -31,6 +32,7 @@
 )
 
 __all__ = [
+    "ParseError",
     "XML",
     "XMLParse",
     "XMLParser",

tests.py

@@ -218,6 +218,15 @@ def test_import_order(self):
 
         self.assertIs(orig_elementtree, second_elementtree)
 
+    def test_orig_parseerror(self):
+        # https://github.com/tiran/defusedxml/issues/63
+        self.assertIs(self.module.ParseError, orig_elementtree.ParseError)
+        try:
+            self.parseString("invalid")
+        except Exception as e:
+            self.assertIsInstance(e, orig_elementtree.ParseError)
+            self.assertIsInstance(e, self.module.ParseError)
+
 
 class TestDefusedcElementTree(TestDefusedElementTree):
     module = cElementTree