Modified host regex to match alternative syntax #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following host rule syntax is valid within traefik: "Host(`subdomain.domain.com`,`subdomain2.domain.com`,`subdomain3.domain.com`)" This configuration was incorrectly parsed previously, and the 'Host' portion of regex is safe to remove based on the "if 'Host' in value:" check.
|
Sorted the regex a little here, since capital letters and numbers are valid (caps will be normalised by CloudFlare). |
|
This is a good change. The same change also need to be applied to the check_service_t2 version btw. |
mbjurstrom
added a commit
to mbjurstrom/docker-traefik-cloudflare-companion
that referenced
this pull request
Oct 6, 2020
The following host rule syntax is valid within traefik: "Host(`subdomain.domain.com`,`subdomain2.domain.com`,`subdomain3.domain.com`)" This configuration was incorrectly parsed previously, and the 'Host' portion of regex is safe to remove based on the "if 'Host' in value:" check. Originally added by dchidell at tiredofit#15 . Just updated it for the current code base. Updated the check_service_t2 method as well as updated the documentation Fixes: tiredofit#16
mbjurstrom
added a commit
to mbjurstrom/docker-traefik-cloudflare-companion
that referenced
this pull request
Oct 6, 2020
The following host rule syntax is valid within traefik: "Host(`subdomain.domain.com`,`subdomain2.domain.com`,`subdomain3.domain.com`)" This configuration was incorrectly parsed previously, and the 'Host' portion of regex is safe to remove based on the "if 'Host' in value:" check. Originally added by dchidell at tiredofit#15 . Just updated it for the current code base. Updated the check_service_t2 method as well as updated the documentation Fixes: tiredofit#16
|
Hi @dchidell - I waited too long to approve this. I just went through my tests now as I was initially resistant to this PR, but it is sound. I've given you credit for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following host rule syntax is valid within traefik:
This configuration was incorrectly parsed previously, and the 'Host' portion
of regex is safe to remove based on the "if 'Host' in value:" check.