Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test cases to check for the positive case as well #4

Merged
merged 2 commits into from Mar 3, 2018

Conversation

ackerleytng
Copy link
Contributor

Hope you like this!

@tirkarthi tirkarthi merged commit eb074a4 into tirkarthi:master Mar 3, 2018
@tirkarthi
Copy link
Owner

Thanks @ackerleytng. This looks great and the tests are much nicer and robust now. Thanks for the reserved namespace too with useful information. Thanks a lot for the contribution. Merged 👍

@ackerleytng
Copy link
Contributor Author

Will you be putting this on clojars? Would like to use this for my project!

@tirkarthi
Copy link
Owner

Sure, I will push a release tonight or before Monday.

@ackerleytng
Copy link
Contributor Author

Thanks! I'm actually working on a version of the validator that takes a predicate instead of a list of regexes or numbers. Still need to work on test cases, might be able to put up a pull request by tomorrow!

@tirkarthi
Copy link
Owner

That's great. Please keep in the existing key :regexes and consider adding a new optional key like :predicates to the function. Feel free to open a new issue to discuss about this since this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants