Add CaiyunService Support #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
抽空弄了下初步支持上了，这周还有其他事情不一定有时间能完全弄完 cc @tisfeng TODO:
|
Kyle-Ye
force-pushed
the
feature/caiyun
branch
from
b4aafac
to
f91eb84
Compare
|
试了一下，看起来不错。 没事，我这边可以自己先做，你稍后抽空完善一下就好。 |
|
你好，这个文件好像是你用 SPM 新增的，我这边提示没有被跟踪， 
|
tisfeng
reviewed
Nov 11, 2023
tisfeng
reviewed
Nov 11, 2023
tisfeng
reviewed
Nov 11, 2023
Kyle-Ye
commented
Nov 12, 2023
Kyle-Ye
force-pushed
the
feature/caiyun
branch
from
077bd1c
to
1b4ca89
Compare
tisfeng
reviewed
Nov 12, 2023
tisfeng
reviewed
Nov 12, 2023
|
我看到 GitGuardian Security Checks 这个警告还在，以为是 token 切割不彻底，但看起来不是，而是因为泄漏 token 的提交记录已经推送了。。 看了一下文档 https://blog.gitguardian.com/rewriting-git-history-cheatsheet/ ，要想消除警告有点麻烦，这只是一个测试 token，问题不大，还是算了吧 😔 |
tisfeng
requested changes
Nov 13, 2023
tisfeng
reviewed
Nov 13, 2023
tisfeng
requested changes
Nov 13, 2023
tisfeng
requested changes
Nov 13, 2023
Kyle-Ye
commented
Nov 13, 2023
tisfeng
requested changes
Nov 14, 2023
This was referenced Nov 14, 2023
Closed
Kyle-Ye
force-pushed
the
feature/caiyun
branch
from
ed454b0
to
b9d07ea
Compare
Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <kyle201817146@gmail.com>
Kyle-Ye
force-pushed
the
feature/caiyun
branch
from
b9d07ea
to
4762aec
Compare
|
@Kyle-Ye 完善了一下代码，你看看还有没有什么要改的 |
Kyle-Ye
commented
Nov 27, 2023
tisfeng
approved these changes
Nov 27, 2023
Jerry23011
pushed a commit
to Jerry23011/Easydict
that referenced
this pull request
Dec 3, 2023
* Fix header issue * Add basic support for CaiyunService Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <kyle201817146@gmail.com> * perf: improve multiple texts translation * chore: add swiftpm/Package.resolved * perf: add more supported languages * perf: rename EZCaiyunAPIKey to EZCaiyunToken * perf: set auto convert Chinese text to true * perf: support traditional Chinese as target language * refactor: auto convert to traditional Chinese texts if need * perf: localize LingoCloud as English name * perf: update Localizable.xcstrings * perf: localize unsupported_translation_type * perf: improve transType() * fix: only auto convert to traditional Chinese when matching query target language * perf: improve supportLanguagesDictionary() --------- Co-authored-by: tisfeng <tisfeng@gmail.com>
tisfeng
added a commit
that referenced
this pull request
Dec 3, 2023
* Fix header issue * Add basic support for CaiyunService Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <kyle201817146@gmail.com> * perf: improve multiple texts translation * chore: add swiftpm/Package.resolved * perf: add more supported languages * perf: rename EZCaiyunAPIKey to EZCaiyunToken * perf: set auto convert Chinese text to true * perf: support traditional Chinese as target language * refactor: auto convert to traditional Chinese texts if need * perf: localize LingoCloud as English name * perf: update Localizable.xcstrings * perf: localize unsupported_translation_type * perf: improve transType() * fix: only auto convert to traditional Chinese when matching query target language * perf: improve supportLanguagesDictionary() --------- Co-authored-by: tisfeng <tisfeng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #206