Revert "Feautre tips view" #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 074bb73.
|
This feature is often triggered by mistake #452 , so let's revert it and fix it later. |
phlpsong
approved these changes
Mar 30, 2024
AkaShark
approved these changes
Mar 30, 2024
AkaShark
added a commit
to AkaShark/Easydict
that referenced
this pull request
Apr 7, 2024
This reverts commit 11fd868.
tisfeng
added a commit
that referenced
this pull request
May 19, 2024
* Revert "Revert "Feautre tips view (#418)" (#477)" This reverts commit 11fd868. * fix: #452 blank for tips view * feat: add type of tips cell * feat: support tips cell update cell type * fix: when selection translation the text is empty set special tips cell type * fix: update show tips status * fix: resolve merge dev * fix: update action type * pref: stash ocr error tips * fix: control show tips code * fix: update view * fix: add mini cell height * fix: tips cell type * fix: remove unuse code * fix: called showTipsView when showTips == true * fix: display when user just want show query window again * perf: improve displaying tips view * perf: do not reload tableView when starting query text * perf: remove unused Localizable.xcstrings * perf: close tips view when just updating query text * perf: close tips view when starting OCR image * chore(deps): bump rexml in the bundler group across 1 directory Bumps the bundler group with 1 update in the / directory: [rexml](https://github.com/ruby/rexml). Updates `rexml` from 3.2.6 to 3.2.8 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.6...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> * perf(UI): add icon for disableTipsView toggle * perf(UI): adjust advanced tab height --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tisfeng <tisfeng@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jerry <89069957+Jerry23011@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #418