fix: support http protocol for custom OpenAI api url #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you for your PR, I have just added the custom model option, we can use ollama for translation now. 
|
|
If there are no issues, I'll submit a version update to the store later. |
|
That would be great |
rookiezn
commented
Mar 7, 2024
| "title": "OpenAI API URL", | ||
| "name": "openAIAPIURL", | ||
| "title": "OpenAI Endpoint", | ||
| "name": "openAIEndpoint", |
There was a problem hiding this comment.
@tisfeng I just noticed you have updated name property of OpenAI API URL option. I am afraid this will cause the endpoint already set by the user to be overwritten by the default value after the update, because it is actually a new option and the old one was removed.
There was a problem hiding this comment.
Thank you reminding, I just fixed it 4907c2e
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might want to deploy OpenAI API service locally, in which case the HTTP protocol is usually used. But currently setting the http url will cause an error when calling the api.
TypeError [ERR_INVALID_PROTOCOL]: Protocol "http:" not supported. Expected "https:"This PR aims to fix this issue.