generated from titan-data/template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tags support #89
Merged
Merged
tags support #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcred
requested changes
Oct 25, 2019
mcred
approved these changes
Oct 25, 2019
mcred
pushed a commit
to mcred/titan
that referenced
this pull request
Oct 29, 2019
Fixes titan-data#82 Fixes titan-data#87 Fixes titan-data#88
mcred
pushed a commit
to mcred/titan
that referenced
this pull request
Oct 29, 2019
Fixes titan-data#82 Fixes titan-data#87 Fixes titan-data#88
mcred
pushed a commit
to mcred/titan
that referenced
this pull request
Oct 31, 2019
Fixes titan-data#82 Fixes titan-data#87 Fixes titan-data#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Fixes #82
Fixes #87
Fixes #88
Proposed Changes
This strings together all the changes to support tags. Other things fixed along the way include cleaning up the progress reporting (just enough while we wait to do a more complete refactor), and augmenting the "checkout" command to default to latest (matching) commit if none is specified.
I also went ahead and added the source commit to the metadata and repo status, since I bumped the titan-server version to 0.5.1.
Testing
Lots of manual testing.