Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scatter plot functionality #5

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Add scatter plot functionality #5

merged 2 commits into from
Jan 11, 2022

Conversation

avonow
Copy link
Contributor

@avonow avonow commented Jan 7, 2022

Adds the option to create a scatter plot.

@avonow
Add scatter plot functionality
be20cb1 
Adds the option to create a scatter plot.
huntc
huntc reviewed Jan 7, 2022
View reviewed changes
Copy link
Contributor

@huntc huntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Would it be possible to provide an example of scatter in use (see how examples are structured…)?

huntc
huntc reviewed Jan 7, 2022
View reviewed changes
src/horizontal_series.rs Outdated Show resolved Hide resolved
@avonow
Match implementation and updated README
a060cca 
If/else statements changed to match, and README.md updated with new images.
@avonow
Copy link
Contributor Author

avonow commented Jan 10, 2022

In the last commit here, I've added images from my scatter implementation and updated the README. I changed the layout slightly, so that the images will be at 70% and centred. If this is not desirable, very happy to revert.

@avonow
Copy link
Contributor Author

avonow commented Jan 10, 2022

We've been informed that the data_labels property can be used for scatter plots, so a separate PR will be raised to just document that with an example, instead of this current PR.

@huntc
Copy link
Contributor

huntc commented Jan 10, 2022

We've been informed that the data_labels property can be used for scatter plots, so a separate PR will be raised to just document that with an example, instead of this current PR.

Thanks so much. That'd be wonderful.

@huntc huntc merged commit 9a48da9 into titanclass:master Jan 11, 2022
@avonow avonow deleted the scatter-plot branch January 27, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntc huntc huntc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avonow @huntc