Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup resizing #9

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Fixup resizing #9

merged 2 commits into from
Mar 1, 2022

Conversation

huntc
Copy link
Contributor

@huntc huntc commented Mar 1, 2022

Resizing doesn't appear to have worked since the Yew upgrade. I believe it may be because we should look for window resize events.

Resizing doesn't appear to have worked since the Yew upgrade. I believe it may be because we should look for window resize events.
@huntc huntc requested a review from RoryStokes March 1, 2022 02:02
Copy link
Contributor

@RoryStokes RoryStokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, we should probably start using the gloo-utils stuff a bit more

@huntc
Copy link
Contributor Author

huntc commented Mar 1, 2022

Neat, we should probably start using the gloo-utils stuff a bit more

Yeah, I was resisting, but then you'd already including gloo-events. :-) Seems like the right thing to do.

@huntc huntc merged commit 9ed7cb1 into titanclass:master Mar 1, 2022
@huntc huntc deleted the fix-resize branch March 1, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants