react 17을 준비합니다. #1469

giwan-dev · 2021-06-29T07:49:46Z

설명

react, react-dom, react-test-renderer를 17로 업그레이드하고, react를 peer 의존성으로 가지는 패키지를 react 17을 지원하는 버전으로 업그레이드합니다.

변경 내역 및 배경

@titicaca/map의 @react-google-maps/api major 버전 업그레이드
@titicaca/slider의 react-compound-slider major 버전 업그레이드
@titicaca/date-picker의 react-day-picker minor 버전 업그레이드 Fix range-picker 의존 모듈이 업데이트되면서 발생하는 type 이슈를 개선합니다. #1340
@titicaca/intersection-observer의 @researchgate/react-intersection-observer를 titicacadev/react-intersection-observer 로 대체

storybook에서 react@16 peer-dep 에러가 발생했지만, --legacy-per-deps 옵션으로 우회합니다. storybook author가 권장하는 방법이라;; 울며 겨자먹기로 사용합니다.

사용 및 테스트 방법

canary

이 PR의 유형

🤔

giwan-dev · 2021-06-29T07:50:22Z

canary release

github-actions · 2021-06-29T07:50:45Z

@zprime0920 I got it! 🚀

rhiokim

👍🏻

github-actions · 2021-06-29T07:59:29Z

v2.28.2-pr-1469.22 has been published!

giwan-dev · 2021-06-30T00:57:00Z

canary release

github-actions · 2021-06-30T00:57:21Z

@zprime0920 I got it! 🚀

github-actions · 2021-06-30T01:04:23Z

v2.28.2-pr-1469.24 has been published!

giwan-dev · 2021-06-30T01:34:28Z

canary release

github-actions · 2021-06-30T01:34:47Z

@zprime0920 I got it! 🚀

github-actions · 2021-06-30T01:42:00Z

v2.28.2-pr-1469.27 has been published!

inbeom · 2021-07-01T02:24:40Z

researchgate/react-intersection-observer#205 하나 열고 왔습니다 .. 반응 보시죠

kooinsung · 2021-07-01T02:30:38Z

researchgate/react-intersection-observer#205 하나 열고 왔습니다 .. 반응 보시죠

nibblebot 가 이욜에게 커피한잔 기부해야겠네여 ㅋㅋ

giwan-dev · 2021-07-01T05:47:54Z

https://github.com/researchgate/react-intersection-observer/pull/196/files
PR 목록 읽다가 이런 걸 봐버렸습니다... 레포가 버려진 걸까요ㅠㅠ

inbeom · 2021-07-01T05:50:23Z

ㅋㅋㅋ 저도 봤는데 봇이라 모르시는 것 같아갖구...

이번 주까지 반응 없으면 포크 해버리시죠

inbeom · 2021-07-05T04:31:37Z

포크하려고 들어왔는데 메인테이너가 이모지를 남겨두셨네요 researchgate/react-intersection-observer#205 뭐지..

inbeom · 2021-07-20T00:59:18Z

https://www.npmjs.com/package/@titicaca/react-intersection-observer 1.5.0으로 릴리즈 해뒀습니다 .. npm 으로는 잘 안 되고 Yarn 필수군요.

giwan-dev · 2021-07-20T01:55:11Z

@inbeom 배포할 때 그냥 yarn run release 하면 되나요? prop 타입이 export 안 되어있어서 export하려고 합니당

inbeom · 2021-07-20T01:55:29Z

yarn publish 하면 됩니다용!

inbeom

👏

그냥 설치하면 storybook의 의존성에서 에러가 발생해서 `--legacy-peer-deps` 옵션을 사용합니다. storybook author의 답변입니다;;

v2부터 react 17을 지원합니다.

@types/googlemaps 설치할 때 @types/google.maps를 사용하라는 deprecate 경고 메시지가 뜹니다. 하지만 @react-google-maps/api가 여전히 이 타입 정의를 사용하고 있기 때문에 @types/google.maps를 사용하지 않습니다.

최신 버전에서 react 17을 peer dependency로 가지기 때문에 업그레이드 합니다.

react 17을 지원하는 버전을 설치합니다.

`@researchgate/react-intersection-observer`를 대체합니다.

giwan-dev · 2021-07-22T01:16:02Z

canary release

github-actions · 2021-07-22T01:16:21Z

@zprime0920 I got it! 🚀

github-actions · 2021-07-22T01:23:29Z

v2.30.3-pr-1469.41 has been published!

inbeom

🚀

torres-triple

🚀

giwan-dev requested a review from a team as a code owner June 29, 2021 07:49

rhiokim previously approved these changes Jun 29, 2021

View reviewed changes

github-actions bot temporarily deployed to June 29, 2021 08:00 Inactive

giwan-dev dismissed rhiokim’s stale review via 82b6493 June 30, 2021 00:54

giwan-dev changed the title ~~react, react-dom, react-test-renderer를 17로 올립니다.~~ react 17을 준비합니다. Jun 30, 2021

github-actions bot temporarily deployed to June 30, 2021 01:04 Inactive

github-actions bot temporarily deployed to June 30, 2021 01:42 Inactive

giwan-dev force-pushed the update-react-17 branch from 7509aa6 to d8f1c3d Compare July 2, 2021 06:27

giwan-dev marked this pull request as draft July 2, 2021 06:30

giwan-dev force-pushed the update-react-17 branch from d8f1c3d to 9932e8a Compare July 20, 2021 04:23

giwan-dev marked this pull request as ready for review July 20, 2021 05:15

giwan-dev added this to the v2.31.0 milestone Jul 20, 2021

giwan-dev requested a review from a team July 20, 2021 05:16

inbeom previously approved these changes Jul 21, 2021

View reviewed changes

inbeom requested a review from a team July 21, 2021 00:19

giwan-dev added 10 commits July 22, 2021 10:13

🔧 lint ignore 목록에 storybook-static 추가

95bfefa

⬆️ react, react-dom, react-test-renderer 17 설치

f2e6a20

그냥 설치하면 storybook의 의존성에서 에러가 발생해서 `--legacy-peer-deps` 옵션을 사용합니다. storybook author의 답변입니다;;

⬆️ @types/react, @types/react-dom 최신 버전 설치

e8624fb

⬆️ map에서 의존하는 @react-google-maps/api 패키지 업데이트

d4d4e73

v2부터 react 17을 지원합니다.

⬆️ date-picker의 react-day-picker 최신 버전으로 업그레이드

f1a1294

최신 버전에서 react 17을 peer dependency로 가지기 때문에 업그레이드 합니다.

🐛 업그레이드로 인한 타입 에러 수정

87d1355

⬆️ slider에서 react-compound-slider 최신 버전으로 업그레이드

6e25cd3

react 17을 지원하는 버전을 설치합니다.

➕ @titicaca/react-intersection-observer 설치

edabe1a

`@researchgate/react-intersection-observer`를 대체합니다.

⬆️ @titicaca/react-intersection-observer 정식 버전 설치

de9f2cb

giwan-dev dismissed inbeom’s stale review via de9f2cb July 22, 2021 01:13

giwan-dev force-pushed the update-react-17 branch from 6223890 to de9f2cb Compare July 22, 2021 01:13

📦 update package-lock.json

d687bc5

github-actions bot temporarily deployed to July 22, 2021 01:23 Inactive

giwan-dev requested review from inbeom and a team and removed request for a team July 22, 2021 01:49

inbeom approved these changes Jul 22, 2021

View reviewed changes

inbeom requested a review from a team July 22, 2021 02:14

torres-triple approved these changes Jul 22, 2021

View reviewed changes

giwan-dev merged commit 019e993 into main Jul 22, 2021

giwan-dev deleted the update-react-17 branch July 22, 2021 02:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

react 17을 준비합니다. #1469

react 17을 준비합니다. #1469

giwan-dev commented Jun 29, 2021 •

edited

Loading

giwan-dev commented Jun 29, 2021

github-actions bot commented Jun 29, 2021

rhiokim left a comment

github-actions bot commented Jun 29, 2021

giwan-dev commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

giwan-dev commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

inbeom commented Jul 1, 2021

kooinsung commented Jul 1, 2021 •

edited

Loading

giwan-dev commented Jul 1, 2021

inbeom commented Jul 1, 2021

inbeom commented Jul 5, 2021

inbeom commented Jul 20, 2021 •

edited

Loading

giwan-dev commented Jul 20, 2021

inbeom commented Jul 20, 2021

inbeom left a comment

giwan-dev commented Jul 22, 2021

github-actions bot commented Jul 22, 2021

github-actions bot commented Jul 22, 2021

inbeom left a comment

torres-triple left a comment

react 17을 준비합니다. #1469

react 17을 준비합니다. #1469

Conversation

giwan-dev commented Jun 29, 2021 • edited Loading

설명

변경 내역 및 배경

사용 및 테스트 방법

이 PR의 유형

giwan-dev commented Jun 29, 2021

github-actions bot commented Jun 29, 2021

rhiokim left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 29, 2021

giwan-dev commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

giwan-dev commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

github-actions bot commented Jun 30, 2021

inbeom commented Jul 1, 2021

kooinsung commented Jul 1, 2021 • edited Loading

giwan-dev commented Jul 1, 2021

inbeom commented Jul 1, 2021

inbeom commented Jul 5, 2021

inbeom commented Jul 20, 2021 • edited Loading

giwan-dev commented Jul 20, 2021

inbeom commented Jul 20, 2021

inbeom left a comment

Choose a reason for hiding this comment

giwan-dev commented Jul 22, 2021

github-actions bot commented Jul 22, 2021

github-actions bot commented Jul 22, 2021

inbeom left a comment

Choose a reason for hiding this comment

torres-triple left a comment

Choose a reason for hiding this comment

giwan-dev commented Jun 29, 2021 •

edited

Loading

kooinsung commented Jul 1, 2021 •

edited

Loading

inbeom commented Jul 20, 2021 •

edited

Loading