Fix bug with unboxed refs #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Apr 24, 2024
| @@ -17,7 +17,10 @@ def getScalarFromSet(s: Scalar.set) -> Scalar { | |||
| return Scalar.B32; // should be unreachable | |||
| } | |||
| def getTypeFromScalarSet(s: Scalar.set, usePacking: bool) -> Type { | |||
| for (i in s) return if(usePacking, IntRep.getType(i), i.ty); | |||
| for (i in s) { | |||
| if (i.tag >= Scalar.R32.tag) return AnyRef.TYPE; | |||
There was a problem hiding this comment.
Checking the tag here is somewhat brittle; I think a match would be best here.
|
Fixed this in a separate CL. If you have a testcase that fails, please share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be using
u32[R32]/u64[R64]at all while packed refs are not supported.Fixes bug so
type Operand #unboxed #packedcan bootstrap.