Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safer </script> regexes #835

Merged
merged 1 commit into from Apr 9, 2022
Merged

fix: safer </script> regexes #835

merged 1 commit into from Apr 9, 2022

Conversation

tivac
Copy link
Owner

@tivac tivac commented Apr 9, 2022

CodeQL flagged these, so making them a bit more flexible

@tivac tivac self-assigned this Apr 9, 2022
@ghost
Copy link

ghost commented Apr 9, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #835 (dd858af) into main (90370d2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          37       37           
  Lines        1435     1435           
  Branches      232      232           
=======================================
  Hits         1429     1429           
  Misses          6        6           
Impacted Files Coverage Δ
packages/svelte/link.js 100.00% <100.00%> (ø)
packages/svelte/script.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c282678...dd858af. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2022

This pull request fixes 2 alerts when merging dd858af into f6c2aed - view on LGTM.com

fixed alerts:

  • 2 for Bad HTML filtering regexp

@tivac tivac merged commit ca589f6 into main Apr 9, 2022
@tivac tivac deleted the safer-script-regexes branch April 9, 2022 23:18
@netlify
Copy link

netlify bot commented Apr 9, 2022

Deploy Preview for m-css ready!

Name Link
🔨 Latest commit dd858af
🔍 Latest deploy log https://app.netlify.com/sites/m-css/deploys/6252130f87900a0008c37093
😎 Deploy Preview https://deploy-preview-835--m-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant