Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct replacements of css.<key> values #436

Merged
merged 4 commits into from Jun 22, 2018

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jun 21, 2018

Previously was using a raw . which would match ANY CHARACTER.

That caused all sorts of issues, with #432 being one example. Now it only replaces a literal . which is much more in-line with the original intent.

Fixes #432

@tivac tivac self-assigned this Jun 21, 2018

@codecov

This comment has been minimized.

Copy link

commented Jun 21, 2018

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          31       31           
  Lines         765      765           
  Branches      114      114           
=======================================
  Hits          758      758           
  Misses          7        7
Impacted Files Coverage Δ
packages/svelte/src/markup.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f413732...5995989. Read the comment docs.

@tivac tivac merged commit b4de308 into master Jun 22, 2018

4 checks passed

codecov/patch Coverage not affected when comparing f413732...5995989
Details
codecov/project 99.08% remains the same compared to f413732
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the too-greedy-svelte branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.