Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rollup dependency removal #442

Merged
merged 5 commits into from Jul 5, 2018
Merged

Fix rollup dependency removal #442

merged 5 commits into from Jul 5, 2018

Commits on Jul 2, 2018

  1. test: try to replicate #441 

    No luck though, need to get a better repro.
    @tivac
    tivac committed Jul 2, 2018
    Copy the full SHA
    11b18e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2018

  1. Got a failing test!

    @tivac
    tivac committed Jul 5, 2018
    Copy the full SHA
    892d308 View commit details
    Browse the repository at this point in the history

  2. chore: 🔒 file wut

    @tivac
    tivac committed Jul 5, 2018
    Copy the full SHA
    1c084a8 View commit details
    Browse the repository at this point in the history

  3. fix: Only remove the file and its dependents 

    Not sure why I changed it to the file and all its dependencies instead of just the default "file and its dependants" behavior, but that was the WRONG choice.
    @tivac
    tivac committed Jul 5, 2018
    Copy the full SHA
    ff3e73e View commit details
    Browse the repository at this point in the history

  4. fix: handle both removal cases 

    See comment on line 53 for the reasoning, it's goofy.
    @tivac
    tivac committed Jul 5, 2018
    Copy the full SHA
    6ad3858 View commit details
    Browse the repository at this point in the history