fix: modular-css-svelte handles empty CSS files #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=========================================
+ Coverage 98.89% 98.9% +<.01%
=========================================
Files 31 31
Lines 815 820 +5
Branches 128 129 +1
=========================================
+ Hits 806 811 +5
Misses 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512, see the issue for the background & investigation.
This only runs the regex replacement if there's anything to replace, and also cleans up some of the error/warning output. As a bonus it also simplifies a lot of the error case test code & cuts down on the number of test cases by a bit.