Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modular-css-svelte handles empty CSS files #513

merged 2 commits into from Aug 29, 2018


None yet
1 participant
Copy link

commented Aug 29, 2018

Fixes #512, see the issue for the background & investigation.

This only runs the regex replacement if there's anything to replace, and also cleans up some of the error/warning output. As a bonus it also simplifies a lot of the error case test code & cuts down on the number of test cases by a bit.

@tivac tivac self-assigned this Aug 29, 2018


This comment has been minimized.

Copy link

commented Aug 29, 2018

Codecov Report

Merging #513 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #513      +/-   ##
+ Coverage   98.89%   98.9%   +<.01%     
  Files          31      31              
  Lines         815     820       +5     
  Branches      128     129       +1     
+ Hits          806     811       +5     
  Misses          9       9
Impacted Files Coverage Δ
packages/svelte/src/markup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5d2b6...8162a53. Read the comment docs.

@tivac tivac merged commit 78ba84b into master Aug 29, 2018

4 of 5 checks passed

deploy/netlify Deploy preview failed.
codecov/patch 100% of diff hit (target 98.89%)
codecov/project 98.9% (+<.01%) compared to 6e5d2b6
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the svelte-empty-file-errors branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.