refactor: postcss8 native support #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 99.40% 99.41% +0.01%
==========================================
Files 34 34
Lines 1343 1370 +27
Branches 216 218 +2
==========================================
+ Hits 1335 1362 +27
Misses 8 8
Continue to review full report at Codecov.
|
|
❌ Deploy Preview for m-css failed. 🔨 Explore the source changes: c7c62db 🔍 Inspect the deploy log: https://app.netlify.com/sites/m-css/deploys/60e3f7b81977a800082411fb |
None of these are doing loop detection yet so this is highly likely to explode in infinite loops in any non-trivial cases. https://gitter.im/postcss/postcss?at=6042bc5ad74bbe49e0d6b71a
Need to roll this out further
TODO: Needs to update/provide the scoping info in real time instead of pushing messages at the end. Maybe the dep graph could be used for that?
Seen has so many gotchas, this may still need reworking though?
Not doing this for @values/composes because it'd slow things down, have to though for @Keyframes unless we want to build a very-complex animation declaration parser.
BREAKING CHANGE: - Requires `postcss@8` be installed alongside to function.
|
This is published as |
Fixes an issue where importing an alias could get you the alias raw value instead of the expected source value.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new APIs in postcss@8 to dramatically speed things up. This is a BREAKING CHANGE as older versions of PostCSS will no longer be supported, and
composesand@valueswill need to be in order in the source file. Previously they could be in any order and it would figure things out, but the new walking APIs preclude that.Motivation and Context
Who knows how long old APIs will keep working, need to keep up. Speed boost doesn't hurt.
How Has This Been Tested?
Tests
Types of changes
Checklist: