Children prop type missing in HeadProvider

[itaditya]

Getting this TS error

Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & { headTags?: ReactElement<unknown, string | JSXElementConstructor>[] | undefined; }'.

Fix for this-

since HeadProvider uses children prop, it's typescript definition should include children: ReactNode

[tizmagik]

Can you create a reproduction on Codesandbox or something? I'm not able to repro... https://codesandbox.io/s/modest-matsumoto-try7wg?file=/src/App.tsx

[itaditya]

here's a simple Vite based app. Let me know if this will do otherwise I'll make one on Stackblitz.

https://github.com/itaditya/friendly-ui/blob/main/packages/react/src/App.tsx

[itaditya]

I noticed the types in your CSB are of React 17 whereas mine are of React 18

"devDependencies": {
"@types/react": "17.0.20",
"@types/react-dom": "17.0.9",
"typescript": "4.4.2"
},

"devDependencies": {
"@types/react": "^18.0.0",
"@types/react-dom": "^18.0.0",
"@vitejs/plugin-react": "^1.3.0",
"typescript": "^4.6.3",
"vite": "^2.9.9"
}

[tizmagik]

Ah, yea I haven't tested react-head against React 18. It's possible it needs some updates. Feel free to open a PR to address any type issues with React 18.

[abhishiv]

Can confirm I face the same issue with react18.

    const H = HeadProvider as any;
    const element = (
      <H headTags={headTags}>
      </H>
    );

[marhaupe]

This MR should fix this issue: #146

[tizmagik]

Fixed in v3.4.2