Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tags not collected #57

Closed
klase opened this issue Aug 16, 2018 · 4 comments
Closed

Some tags not collected #57

klase opened this issue Aug 16, 2018 · 4 comments

Comments

@klase
Copy link

klase commented Aug 16, 2018

When trying to add the following Meta tags (3.0.0-1):

<Title>{title}</Title>
<Meta name="description" content="The title" />
<Meta property="og:description" content="Some description" />
<Meta property="og:image" content="http://example.com/image.jpg" />
<Meta property="og:title" content="OG title" />
<Meta property="og:sometag" content="someValue" />

Only the first and last one is actually collected and rendered.
@TrySound
Copy link
Collaborator

What sense have property attribute in meta tag? Do you have any spec references? For now meta tags are distinguished only by name attribute, so in your case there're two meta with "description" name and undefined name.

@klase
Copy link
Author

klase commented Aug 16, 2018 •
edited

It is used in the open graph protocol (http://ogp.me/) which was originally created by Facebook but is now managed by the Open Web Foundation.

@TrySound
Copy link
Collaborator

Okay, I think distinguishing by name || property should work.

TrySound added a commit that referenced this issue Aug 16, 2018
@TrySound
Support open graph protocol
2cd3d8c 
Ref #57

I simply added `name || property` key to support both properties as
identifier.
@TrySound TrySound mentioned this issue Aug 16, 2018
Merged
TrySound added a commit that referenced this issue Aug 17, 2018
@TrySound
Support open graph protocol (#58)
4f8a383 
Ref #57

I simply added `name || property` key to support both properties as
identifier.
@tizmagik
Copy link
Owner

I think this was addressed in #58 so closing. @klase please re-open or create a new issue if you see any problems! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tizmagik @klase @TrySound