Add support for cascading titles #37
Conversation
|
@tizmagik Could you take a look? |
|
Awesome to see this! Nice job. I will take a closer look tomorrow; I want to ensure that this implementation is completely thread-safe. I think it might be possible to test for this in the test suite, actually. What do you think about setting up an async test with two render requests simultaneously and ensure that the responses are properly thread-safe? |
|
The idea of this implementation is keeping state inside provider so HeadTag could rely on it and render null when a title is not the last one. So this shouldn't work correctly with two react instances. |
|
Or do you mean parallel subtrees? |
|
Yes I mean in parallel |
|
Will add test tomorrow then |
TrySound
force-pushed
the
cascading-titles
branch
from
5b26635
to
e5dc873
Compare
|
@tizmagik Done. Fixed dynamic insertion. Right now it works only for titles. I need this asap. Can we release Will add support for meta[name] in the next PR. For which tags this behaviour is also matter? |
Ref #11 This PR is cascading titles MVP. My project requires similar to helment behaviour for titles.
TrySound
force-pushed
the
cascading-titles
branch
from
e07ebab
to
427c586
Compare
|
Sure, will publish this branch against |
|
Cool. Thanks |
Ref tizmagik#11 This PR is cascading titles MVP. My project requires similar to helment behaviour for titles.
Ref #11
This PR is cascading titles MVP. My project requires similar to helment
behaviour for titles.