Don't add 2 newlines if nothing in table (#423)

Co-authored-by: Tonye Jack <jtonye@ymail.com>
tj-actions · Mar 10, 2023 · 571f879 · 571f879
1 parent 7f48c5f
commit 571f879
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/internal/types/action.go b/internal/types/action.go
@@ -84,11 +84,11 @@ func (a *Action) WriteDocumentation(inputTable, outputTable *strings.Builder) er
 		[]byte(internal.InputAutoDocEnd),
 	)
 
+	inputsStr := strings.TrimSpace(fmt.Sprintf("%s\n\n%v", internal.InputsHeader, inputTable.String()))
+
 	if hasInputsData {
-		inputsStr := fmt.Sprintf("%s\n\n%v", internal.InputsHeader, inputTable.String())
 		output = utils.ReplaceBytesInBetween(input, inputStartIndex, inputEndIndex, []byte(inputsStr))
 	} else {
-		inputsStr := fmt.Sprintf("%s\n\n%v", internal.InputsHeader, inputTable.String())
 		output = bytes.Replace(input, []byte(internal.InputsHeader), []byte(inputsStr), -1)
 	}
 
@@ -98,11 +98,11 @@ func (a *Action) WriteDocumentation(inputTable, outputTable *strings.Builder) er
 		[]byte(internal.OutputAutoDocEnd),
 	)
 
+	outputsStr := strings.TrimSpace(fmt.Sprintf("%s\n\n%v", internal.OutputsHeader, outputTable.String()))
+
 	if hasOutputsData {
-		outputsStr := fmt.Sprintf("%s\n\n%v", internal.OutputsHeader, outputTable.String())
 		output = utils.ReplaceBytesInBetween(output, outputStartIndex, outputEndIndex, []byte(outputsStr))
 	} else {
-		outputsStr := fmt.Sprintf("%s\n\n%v", internal.OutputsHeader, outputTable.String())
 		output = bytes.Replace(output, []byte(internal.OutputsHeader), []byte(outputsStr), -1)
 	}
 

diff --git a/internal/types/reusable.go b/internal/types/reusable.go
@@ -95,12 +95,12 @@ func (r *Reusable) WriteDocumentation(inputTable, outputTable, secretsTable *str
 		[]byte(internal.InputsHeader),
 		[]byte(internal.InputAutoDocEnd),
 	)
+
+	inputsStr := strings.TrimSpace(fmt.Sprintf("%s\n\n%v", internal.InputsHeader, inputTable.String()))
 
 	if hasInputsData {
-		inputsStr := fmt.Sprintf("%s\n\n%v", internal.InputsHeader, inputTable.String())
 		output = utils.ReplaceBytesInBetween(input, inputStartIndex, inputEndIndex, []byte(inputsStr))
 	} else {
-		inputsStr := fmt.Sprintf("%s\n\n%v", internal.InputsHeader, inputTable.String())
 		output = bytes.Replace(input, []byte(internal.InputsHeader), []byte(inputsStr), -1)
 	}
 
@@ -110,11 +110,11 @@ func (r *Reusable) WriteDocumentation(inputTable, outputTable, secretsTable *str
 		[]byte(internal.OutputAutoDocEnd),
 	)
 
+	outputsStr := strings.TrimSpace(fmt.Sprintf("%s\n\n%v", internal.OutputsHeader, outputTable.String()))
+
 	if hasOutputsData {
-		outputsStr := fmt.Sprintf("%s\n\n%v", internal.OutputsHeader, outputTable.String())
 		output = utils.ReplaceBytesInBetween(output, outputStartIndex, outputEndIndex, []byte(outputsStr))
 	} else {
-		outputsStr := fmt.Sprintf("%s\n\n%v", internal.OutputsHeader, outputTable.String())
 		output = bytes.Replace(output, []byte(internal.OutputsHeader), []byte(outputsStr), -1)
 	}
 
@@ -123,12 +123,12 @@ func (r *Reusable) WriteDocumentation(inputTable, outputTable, secretsTable *str
 		[]byte(internal.SecretsHeader),
 		[]byte(internal.SecretsAutoDocEnd),
 	)
+
+	secretsStr := strings.TrimSpace(fmt.Sprintf("%s\n\n%v", internal.SecretsHeader, secretsTable.String()))
 
 	if hasSecretsData {
-		secretsStr := fmt.Sprintf("%s\n\n%v", internal.SecretsHeader, secretsTable.String())
 		output = utils.ReplaceBytesInBetween(output, secretsStartIndex, secretsEndIndex, []byte(secretsStr))
 	} else {
-		secretsStr := fmt.Sprintf("%s\n\n%v", internal.SecretsHeader, secretsTable.String())
 		output = bytes.Replace(output, []byte(internal.SecretsHeader), []byte(secretsStr), -1)
 	}