Skip to content

Commit

Permalink
feat: add support for forcing the use of GitHub’s REST API (#1849)
Browse files Browse the repository at this point in the history
Co-authored-by: GitHub Action <action@github.com>
  • Loading branch information
jackton1 and actions-user committed Jan 13, 2024
1 parent a57f4dc commit 0ca1c07
Show file tree
Hide file tree
Showing 7 changed files with 79 additions and 13 deletions.
29 changes: 29 additions & 0 deletions .github/workflows/multi-job-test.yml
Expand Up @@ -36,3 +36,32 @@ jobs:
- name: List all changed files
run: |
echo '${{ needs.changed-files.outputs.all_changed_files }}'
changed-files-rest-api:
name: Get changed files using REST API
runs-on: ubuntu-latest
outputs:
all_changed_files: ${{ steps.changed-files.outputs.all_changed_files }}
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Get changed files
id: changed-files
continue-on-error: ${{ github.event_name == 'push' }}
uses: ./
with:
use_rest_api: true
- name: List all changed files
run: echo '${{ steps.changed-files.outputs.all_changed_files }}'

view-changed-files-rest-api:
name: View all changed files using REST API
runs-on: ubuntu-latest
needs: [changed-files-rest-api]
steps:
- name: List all changed files
run: |
echo '${{ needs.changed-files-rest-api.outputs.all_changed_files }}'
2 changes: 1 addition & 1 deletion .github/workflows/workflow-run-test.yml
@@ -1,4 +1,4 @@
name: Workflow Run Exmaple
name: Workflow Run Example
on:
workflow_run:
workflows: [Matrix Test]
Expand Down
4 changes: 4 additions & 0 deletions action.yml
Expand Up @@ -203,6 +203,10 @@ inputs:
description: "Github API URL."
required: false
default: ${{ github.api_url }}
use_rest_api:
description: "Force the use of Github's REST API even when a local copy of the repository exists"
required: false
default: "false"
fail_on_initial_diff_error:
description: "Fail when the initial diff fails."
required: false
Expand Down
26 changes: 20 additions & 6 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion src/inputs.ts
Expand Up @@ -53,6 +53,7 @@ export type Inputs = {
failOnInitialDiffError: boolean
failOnSubmoduleDiffError: boolean
negationPatternsFirst: boolean
useRestApi: boolean
}

export const getInputs = (): Inputs => {
Expand Down Expand Up @@ -228,6 +229,10 @@ export const getInputs = (): Inputs => {
}
)

const useRestApi = core.getBooleanInput('use_rest_api', {
required: false
})

const inputs: Inputs = {
files,
filesSeparator,
Expand Down Expand Up @@ -280,7 +285,8 @@ export const getInputs = (): Inputs => {
outputRenamedFilesAsDeletedAndAdded,
token,
apiUrl,
negationPatternsFirst
negationPatternsFirst,
useRestApi
}

if (fetchDepth) {
Expand Down
21 changes: 17 additions & 4 deletions src/main.ts
Expand Up @@ -243,23 +243,36 @@ export async function run(): Promise<void> {
})
core.debug(`Yaml file patterns: ${JSON.stringify(yamlFilePatterns)}`)

if (inputs.useRestApi && !github.context.payload.pull_request?.number) {
throw new Error(
"Only pull_request* events are supported when using GitHub's REST API."
)
}

if (
inputs.token &&
github.context.payload.pull_request?.number &&
!hasGitDirectory
(!hasGitDirectory || inputs.useRestApi)
) {
core.info("Using GitHub's REST API to get changed files")
const unsupportedInputs: (keyof Inputs)[] = [
'sha',
'baseSha',
'since',
'until',
'path',
'quotePath',
'diffRelative',
'sinceLastRemoteCommit',
'recoverDeletedFiles',
'recoverDeletedFilesToDestination',
'recoverFiles',
'recoverFilesSeparator',
'recoverFilesIgnore',
'recoverFilesIgnoreSeparator',
'includeAllOldNewRenamedFiles',
'oldNewSeparator',
'oldNewFilesSeparator',
'skipInitialFetch',
'fetchSubmoduleHistory',
'dirNamesDeletedFilesIncludeOnlyDeletedDirs'
Expand All @@ -280,10 +293,9 @@ export async function run(): Promise<void> {
} else {
if (!hasGitDirectory) {
core.info(`Running on a ${github.context.eventName} event...`)
core.setFailed(
"Can't find local .git directory. Please run actions/checkout before this action. If you intend to use Github's REST API note that only pull_request* events are supported."
throw new Error(
"Can't find local .git directory. Please run actions/checkout before this action (Make sure the path specified in the 'path' input is correct). If you intend to use Github's REST API note that only pull_request* events are supported."
)
return
}

core.info('Using local .git directory')
Expand All @@ -302,5 +314,6 @@ if (!process.env.TESTING) {
// eslint-disable-next-line github/no-then
run().catch(e => {
core.setFailed(e.message || e)
process.exit(1)
})
}

0 comments on commit 0ca1c07

Please sign in to comment.