Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] any_changed doesn't capture changes due to deleting files #148

Closed
2 tasks done
linnea-foreflight opened this issue Jul 30, 2021 · 3 comments · Fixed by #149
Closed
2 tasks done

[Feature] any_changed doesn't capture changes due to deleting files #148

linnea-foreflight opened this issue Jul 30, 2021 · 3 comments · Fixed by #149
Labels
enhancement New feature or request

Comments

@linnea-foreflight
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug?

I would expect any_changed to be true when there is a deleted file. It looks like any changed doesn't take deleted files into account.

To Reproduce

Delete a file in the specified directory and then check the any_changed flag.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

If there is anything listed for "All changed files" that the any_changed flag would be true.

Relevant log output

Checking for file changes: "automated-testing-gaps.md"...  
  Checking for file changes: "AutomatedTests"...
  Added files: 
  Copied files: 
  Deleted files: AutomatedTests/SettingsMonitorTests.swift
  Modified files: 
  Renamed files: 
  Type Changed files: 
  Unmerged files: 
  Unknown files: 
  All changed files: ffm/AutomatedTests/SettingsMonitorTests.swift
  All modified files: 
  Input files: automated-testing-gaps.md AutomatedTests
  Matching modified files: 
  Non Matching modified files: UserPreferences.m AppDelegate.m

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@linnea-foreflight linnea-foreflight added the bug Something isn't working label Jul 30, 2021
jackton1 added a commit that referenced this issue Jul 30, 2021
@jackton1 jackton1 added the enhancement New feature or request label Jul 30, 2021
@jackton1 jackton1 changed the title [BUG] any_changed doesn't capture changes due to deleting files [Feature] any_changed doesn't capture changes due to deleting files Jul 30, 2021
@jackton1 jackton1 removed the bug Something isn't working label Jul 30, 2021
@jackton1
Copy link
Member

@linnea-foreflight This should be resolved in the latest release. Thanks

@linnea-foreflight
Copy link
Author

Thanks!

@jackton1
Copy link
Member

jackton1 commented Aug 20, 2021

@linnea-foreflight Just a heads up decided to stick with the previous design in the latest release.

Even though a deleted file can be considered as modified but the general use case would be for files that are changed or renamed and still available in version control, like you mentioned as opposed to deleted files.

You can use outputs.deleted_files to get around the issue in the meantime.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants