Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support the same filter syntax as GitHub Workflows #264

Closed
2 tasks done
solarmosaic-kflorence opened this issue Nov 29, 2021 · 1 comment · Fixed by #304
Closed
2 tasks done

[Feature] Support the same filter syntax as GitHub Workflows #264

solarmosaic-kflorence opened this issue Nov 29, 2021 · 1 comment · Fixed by #304
Labels
enhancement New feature or request

Comments

@solarmosaic-kflorence
Copy link

solarmosaic-kflorence commented Nov 29, 2021

Is this feature missing in the latest version?

  • I'm using the latest release

Is your feature request related to a problem? Please describe.

This action would be more intuitive and easier to use if it supported the same file filtering syntax as GitHub Workflows support natively. I realize the reason it does not is because it's easier to just accept the input that is used natively by the underlying bash commands. But I'm curious if this is something that could eventually be implemented.

Describe the solution you'd like?

Use syntax like foo/**/bar instead of ^foo/.*/bar, or **/*.md instead of or \.md$. Exclusion rules could either be supported with ! rules, or in a separate input (e.g. exclude-files).

Describe alternatives you've considered?

No response

Anything else?

https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

Code of Conduct

  • I agree to follow this project's Code of Conduct
@solarmosaic-kflorence solarmosaic-kflorence added the enhancement New feature or request label Nov 29, 2021
jackton1 added a commit that referenced this issue Jan 5, 2022
* Add support for using github's glob pattern syntax

Fixes: #264 #265

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update action.yml

* Update action.yml

* Update action.yml

* Update action.yml

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update sourcefiles.sh

* Update action.yml

* Update test.yml

* Update changed-files-list.txt

* Update changed-files-list.txt

* Update action.yml

* Update action.yml

* Update entrypoint.sh

* Update test.yml

* Update README.md

* Update test.yml

* Update entrypoint.sh

* Update test.yml

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jackton1
Copy link
Member

jackton1 commented Jan 5, 2022

@solarmosaic-kflorence This should now be available in the latest release. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants