Can't get since_last_remote_commit to work properly on pull_request event
#276
Labels
enhancement
New feature or request
Comments
|
Thanks for reporting this issue. |
|
Can you try using the latest release: |
|
I have but I get the same results |
|
Can you add more information about the full workflow setup, also note that the |
steps:
- name: Checkout code
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Comprobar qué archivos han cambiado
id: changed-files
uses: tj-actions/changed-files@v11.8
with:
since_last_remote_commit: 'true'
- name: Dockerfile o requerimientos han cambiado
id: set-output
run: |
for file in ${{ steps.changed-files.outputs.modified_files }}; do
echo "$file was added"
doneThat the whole setup. |
|
What's the output from the logs ?? Ideally uploading the logs would be helpful. |
|
Sure, |
|
It seems to me like its not comparing to the right commit |
|
From the logs seems this is triggered by a pull_request based event which uses the last commit on the base branch in this case main (latest commit/HEAD) -> PR branch (latest commit/HEAD) If you'll like to use the last remote commit on the same branch you can switch on:
pull_request:
branches:
- mainTO on:
push:
branches:
- "**" # OR: Objetivo-6 |
|
But I want the action to only trigger on pull requests |
|
Which commit are you expecting to use ??
|
|
The last commit on the pull request branch |
jackton1
added a commit
that referenced
this issue
Dec 4, 2021
jackton1
added a commit
that referenced
this issue
Dec 4, 2021
* Fixed regression bug with base_sha for pull_request Fixes: #276 * Update action.yml * Update entrypoint.sh * Update entrypoint.sh * Update entrypoint.sh * Update entrypoint.sh
|
@Balrrach This should be resolved in the latest release. Thanks |
|
I can confirm the problem is solved. Thanks a lot for the fast answer! |
Balrrach
changed the title
since_last_remote_commit to work properly on pull_request eventsince_last_remote_commit to work properly on pull_request event
Balrrach
changed the title
since_last_remote_commit to work properly on pull_request eventsince_last_remote_commit to work properly on pull_request event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this feature missing in the latest version?
Is your feature request related to a problem? Please describe.
If I am not mistaken
since_last_remote_commitoption compares all changes between the last commit available in remote.When using the next step:
I get the following result:
README.md iv.yaml package.jsonI am changing only the github action file between pushes, how is it possible?. What am I missing?.
Describe the solution you'd like?
Explanation of current behabior
Describe alternatives you've considered?
No response
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: