Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage #1435

Merged
merged 3 commits into from
Aug 5, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/__tests__/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -421,5 +421,25 @@
'test/migrations/test.sql'
])
})

// Tests that getFilteredChangedFiles correctly filters files using ignore glob patterns
it('should filter files using ignore glob patterns', async () => {
const allDiffFiles = {
[ChangeTypeEnum.Added]: [],
[ChangeTypeEnum.Copied]: [],
[ChangeTypeEnum.Deleted]: [],
[ChangeTypeEnum.Modified]: ['assets/scripts/configure-minikube-linux.sh'],

Check failure on line 431 in src/__tests__/utils.test.ts

View workflow job for this annotation

GitHub Actions / build

Replace `'assets/scripts/configure-minikube-linux.sh'` with `⏎··········'assets/scripts/configure-minikube-linux.sh'⏎········`

Check failure on line 431 in src/__tests__/utils.test.ts

View workflow job for this annotation

GitHub Actions / build

Replace `'assets/scripts/configure-minikube-linux.sh'` with `⏎··········'assets/scripts/configure-minikube-linux.sh'⏎········`
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
[ChangeTypeEnum.Renamed]: [],
[ChangeTypeEnum.TypeChanged]: [],
[ChangeTypeEnum.Unmerged]: [],
[ChangeTypeEnum.Unknown]: []
}
const filePatterns = ['assets/scripts/**.sh', 'assets/scripts/configure-minikube-linux.sh']

Check failure on line 437 in src/__tests__/utils.test.ts

View workflow job for this annotation

GitHub Actions / build

Replace `'assets/scripts/**.sh',·'assets/scripts/configure-minikube-linux.sh'` with `⏎········'assets/scripts/**.sh',⏎········'assets/scripts/configure-minikube-linux.sh'⏎······`

Check failure on line 437 in src/__tests__/utils.test.ts

View workflow job for this annotation

GitHub Actions / build

Replace `'assets/scripts/**.sh',·'assets/scripts/configure-minikube-linux.sh'` with `⏎········'assets/scripts/**.sh',⏎········'assets/scripts/configure-minikube-linux.sh'⏎······`
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
const filteredFiles = await getFilteredChangedFiles({
allDiffFiles,
filePatterns
})
expect(filteredFiles[ChangeTypeEnum.Modified]).toEqual([])
})
})
})
Loading