Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement path parameter #168

Merged
merged 9 commits into from
Aug 28, 2021
Merged

Implement path parameter #168

merged 9 commits into from
Aug 28, 2021

Conversation

IvanPizhenko
Copy link
Contributor

@IvanPizhenko IvanPizhenko commented Aug 26, 2021

This PR implements path parameter (similar to GitHub checkout action) to be able to work with multiple repositories.

close #167

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix. Could you include a test that covers your changes.

@IvanPizhenko
Copy link
Contributor Author

@jackton1 Please have a look.

@jackton1
Copy link
Member

@IvanPizhenko Thanks for making the update. I’ll take a look early tomorrow

@IvanPizhenko
Copy link
Contributor Author

@jackton1 Thank you. I also hope you'll tag new version right after accepting this. If something needs to be changed/improved - let me know.

.github/workflows/test.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
@jackton1
Copy link
Member

jackton1 commented Aug 27, 2021

@IvanPizhenko Added some recommendations on improvements. I'll run the test/approve as soon as it's updated. Thanks

@IvanPizhenko
Copy link
Contributor Author

@IvanPizhenko Added some recommendations on improvements. I'll run the test/approve as soon as it's updated. Thanks

@jackton1 Thank you for review. I've implemented your recommendations. Please recheck.

entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
@IvanPizhenko
Copy link
Contributor Author

@jackton1 I am wondering, why you have added this one?

+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0

Typical layout with multiple repositories is such that each repository sits in the own directory under $GITHUB_WORKSPACE and there is nothing else there.

@jackton1
Copy link
Member

@jackton1 I am wondering, why you have added this one?

+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0

Typical layout with multiple repositories is such that each repository sits in the own directory under $GITHUB_WORKSPACE and there is nothing else there.

This is to resolve the error with the test.

Since we are trying to use the local action located in the current path as opposed to a subfolder.

uses: ./

@jackton1 jackton1 merged commit 8a41500 into tj-actions:main Aug 28, 2021
@jackton1
Copy link
Member

@allcontributors add @IvanPizhenko for code and docs

@allcontributors
Copy link
Contributor

@jackton1

@IvanPizhenko already contributed before to code, doc

@jackton1
Copy link
Member

@allcontributors add @IvanPizhenko for code and docs

@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @IvanPizhenko! 🎉

@IvanPizhenko IvanPizhenko deleted the issue-2-checkout-path branch August 28, 2021 07:24
@IvanPizhenko
Copy link
Contributor Author

@jackton1 Thank you for accepting this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for checkout path
2 participants