-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement path parameter #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing a fix. Could you include a test that covers your changes.
@jackton1 Please have a look. |
@IvanPizhenko Thanks for making the update. I’ll take a look early tomorrow |
@jackton1 Thank you. I also hope you'll tag new version right after accepting this. If something needs to be changed/improved - let me know. |
@IvanPizhenko Added some recommendations on improvements. I'll run the test/approve as soon as it's updated. Thanks |
@jackton1 Thank you for review. I've implemented your recommendations. Please recheck. |
@jackton1 I am wondering, why you have added this one? + - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 0 Typical layout with multiple repositories is such that each repository sits in the own directory under |
This is to resolve the error with the test. Since we are trying to use the local action located in the current path as opposed to a subfolder.
|
@allcontributors add @IvanPizhenko for code and docs |
@IvanPizhenko already contributed before to code, doc |
@allcontributors add @IvanPizhenko for code and docs |
I've put up a pull request to add @IvanPizhenko! 🎉 |
@jackton1 Thank you for accepting this contribution! |
This PR implements
path
parameter (similar to GitHub checkout action) to be able to work with multiple repositories.close #167