Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update safe output regex and the docs #1805

Merged
merged 11 commits into from
Dec 23, 2023
Merged

fix: update safe output regex and the docs #1805

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
433b510
Updated README.md
jackton1 Dec 22, 2023
5cb7b01
Merge 433b510018dc26db9a49f961720c94df69eeba32 into 0102c07446a3cad97…
tj-actions-bot Dec 22, 2023
2a1cb8b
Added missing changes and modified dist assets.
actions-user Dec 22, 2023
c9350d5
Update utils.ts
jackton1 Dec 23, 2023
2a6a88e
Update src/utils.ts
jackton1 Dec 23, 2023
6b25cea
Update utils.ts
jackton1 Dec 23, 2023
14d26d4
Merge 6b25cea24b44e9398dbc3ee6a77bcfcca96c9a93 into 0102c07446a3cad97…
tj-actions-bot Dec 23, 2023
028ca44
Added missing changes and modified dist assets.
actions-user Dec 23, 2023
bbfefd5
Update utils.ts
jackton1 Dec 23, 2023
ade1d20
Merge bbfefd5e13abe36f5dd192902a93d6674acd59dd into 0102c07446a3cad97…
tj-actions-bot Dec 23, 2023
104bc6e
Added missing changes and modified dist assets.
actions-user Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,12 @@ Support this project with a :star:
# Default: "\n"
recover_files_separator: ''

# Apply sanitization to output filenames before being set as
# output.
# Type: boolean
# Default: "true"
safe_output: ''

# Split character for output strings.
# Type: string
# Default: " "
Expand Down
47 changes: 33 additions & 14 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,8 +1355,8 @@

// if safeOutput is true, escape special characters for bash shell
if (safeOutput) {
cleanedValue = cleanedValue.replace(/[$()`|&;]/g, '\\$&')
cleanedValue = cleanedValue.replace(/[\x00-\x1F\x7F-\x9F\/\\:\*\?\"<>\|;`$()\&|\!]/g, '\\$&')
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
}

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected control character(s) in regular expression: \x00, \x1f

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \/

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \*

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \?

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \"

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \|

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \&

Check failure on line 1359 in src/utils.ts

View workflow job for this annotation

GitHub Actions / build 

Unnecessary escape character: \!

core.setOutput(key, cleanedValue)

Expand Down