Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore admin import to Django Admin example #728

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

erictheise
Copy link
Contributor

I believe this was an oversight. The @admin.register() decorator does not function without it and my app requires TabularInline. Your own sample requires it.

I believe this was an oversight. The `@admin.register()` decorator does not function without it and my app requires `TabularInline`. Your own [sample](https://raw.githubusercontent.com/tj-django/django-clone/main/sample/admin.py) requires it.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

@jackton1
Copy link
Member

@all-contributors please add @erictheise for docs

@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @erictheise! 🎉

@jackton1 jackton1 merged commit 55ad390 into tj-django:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants