Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to match README syntax #40

Merged
merged 3 commits into from Sep 25, 2012
Merged

fix to match README syntax #40

merged 3 commits into from Sep 25, 2012

Conversation

athibaud
Copy link
Contributor

  • the asset README indicates that you can specify a ./assets.json like so:
    { "jquery": "1.7.2", "backbone": "0.9.2" }
    but in the code you were expecting this syntax:
    { "jquery": { "version": "1.7.2" }, "backbone": { "version": "0.9.2" } }
    fixed to match README syntax.
  • when compress is defined in the ./.asset file, the options isn't accounted for when asset uses the ./assets.json file. fixed.

Thibaud Cummings added 3 commits June 14, 2012 02:28
- properly reads 'version' in ./assets.json if exists
- properly reads ./.asset compress option if ./assets.json exists
@athibaud
Copy link
Contributor Author

would you mind accepting this?
I still use asset (my fork of it for now) but npm doesn't like git dependencies too well.

tj added a commit that referenced this pull request Sep 25, 2012
fix to match README syntax
@tj tj merged commit b6ec6ce into tj:master Sep 25, 2012
@athibaud
Copy link
Contributor Author

thank you, just needs that final push to the npm : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants