Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

fix to match README syntax #40

Merged
merged 3 commits into from

2 participants

@athibaud
  • the asset README indicates that you can specify a ./assets.json like so:
    { "jquery": "1.7.2", "backbone": "0.9.2" }
    but in the code you were expecting this syntax:
    { "jquery": { "version": "1.7.2" }, "backbone": { "version": "0.9.2" } }
    fixed to match README syntax.

  • when compress is defined in the ./.asset file, the options isn't accounted for when asset uses the ./assets.json file. fixed.

athibaud added some commits
@athibaud athibaud fix to match README syntax
- properly reads 'version' in ./assets.json if exists
- properly reads ./.asset compress option if ./assets.json exists
2d0080e
@athibaud athibaud included jade-runtime to assets.json cf9e638
@athibaud athibaud Release 0.4.12 70b30f0
@athibaud

would you mind accepting this?
I still use asset (my fork of it for now) but npm doesn't like git dependencies too well.

@tj tj merged commit b6ec6ce into from
@athibaud

thank you, just needs that final push to the npm : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 14, 2012
  1. @athibaud

    fix to match README syntax

    athibaud authored
    - properly reads 'version' in ./assets.json if exists
    - properly reads ./.asset compress option if ./assets.json exists
Commits on Sep 21, 2012
  1. @athibaud
Commits on Sep 25, 2012
  1. @athibaud

    Release 0.4.12

    athibaud authored
This page is out of date. Refresh to see the latest.
View
5 History.md
@@ -1,3 +1,8 @@
+0.4.12 / 2012-09-25
+==================
+
+ * fix to match README syntax (compression option)
+ * added jade-runtime
0.4.11 / 2012-06-13
==================
View
7 assets.json
@@ -360,5 +360,12 @@
"description": "Minimal templating with {{mustaches}} in JavaScript",
"version": "0.3.0",
"tags": ["js", "templates", "templating"]
+ },
+ "jade-runtime": {
+ "url": "https://github.com/visionmedia/jade/raw/{version}/runtime.js",
+ "description": "jade template engine for client-side use",
+ "compressed": "runtime.min.js",
+ "tags": ["template"],
+ "version": "0.27.4"
}
}
View
2  bin/asset
@@ -156,7 +156,7 @@ process.on('exit', function(){ console.log(); });
function assetsFromObject(obj) {
var arr = [];
for (var asset in obj) {
- arr.push({ name: asset, version: obj[asset].version });
+ arr.push({ name: asset, version: obj[asset], compress: options.compress });
}
return arr;
}
View
2  lib/asset.js
@@ -15,7 +15,7 @@ var Installer = require('./installer');
* Library version.
*/
-exports.version = '0.4.11';
+exports.version = '0.4.12';
/**
* Install `assets` with `repo` object, and `dest` directory.
View
2  package.json
@@ -1,5 +1,5 @@
{ "name": "asset"
- , "version": "0.4.11"
+ , "version": "0.4.12"
, "description": "Asset manager"
, "keywords": ["assets", "javascript", "css", "package manager"]
, "author": "TJ Holowaychuk <tj@vision-media.ca>"
Something went wrong with that request. Please try again.