Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit breaking notes #1006

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

shadowspawn
Copy link
Collaborator

I had a breakage in one of my own projects due to the TypeScript changes and added an example of the fix.

While I was doing that, I added some Breaking notes to the items more likely to affect people using the relevant changed code.

@shadowspawn
Copy link
Collaborator Author

I have no other changes in mind. Ready for release when suits you @abetomo. Exciting release!

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s nice!

@abetomo
Copy link
Collaborator

abetomo commented Aug 6, 2019

Can't publish with the same version, so version 3.0.0-1?

@shadowspawn
Copy link
Collaborator Author

shadowspawn commented Aug 6, 2019

Prerelease version numbers: 3.0.0-0, 3.0.0-1
turn into
Release version number: 3.0.0

A bit tricky. Documented here: https://semver.org/#spec-item-9

@shadowspawn
Copy link
Collaborator Author

I'll merge and bump version now.

@shadowspawn shadowspawn merged commit 41d0bdb into tj:release/3.0.0 Aug 6, 2019
@shadowspawn shadowspawn deleted the feature/breaking branch August 7, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants