Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message when an unknown option and two args are given #121

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -461,21 +461,26 @@ Command.prototype.normalize = function(args){
*/

Command.prototype.parseArgs = function(args, unknown){
var cmds = this.commands
, len = cmds.length
var cmdTriggered = false
, name;

// If there were a command named args[0],
// then we notify args and unknown options to it.
if (args.length) {
name = args[0];
if (this.listeners(name).length) {
this.emit(args.shift(), args, unknown);
} else {
this.emit('*', args);
cmdTriggered = true;
} else if (this.listeners('*').length) {
this.emit('*', args, unknown);
cmdTriggered = true;
}
} else {
}

if (!cmdTriggered) {
outputHelpIfNecessary(this, unknown);
// If there were no args and we have unknown options,

// If we have unknown options,
// then they are extraneous and we need to error.
if (unknown.length > 0) {
this.unknownOption(unknown[0]);
Expand Down
42 changes: 42 additions & 0 deletions test/test.options.args.unknown.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/**
* Module dependencies.
*/

var program = require('../')
, should = require('should');

program
.version('0.0.1')
.option('-f, --foo', 'add some foo')
.option('-b, --bar', 'add some bar');

// Make sure we still catch errors with required values for options
var exceptionOccurred = false;
var oldProcessExit = process.exit;
var oldConsoleError = console.error;
process.exit = function() { exceptionOccurred = true; throw new Error(); };
console.error = function() {};

try {
program.parse(['node', 'test', '--foo', '--unknown']);
} catch (ex) {
}
exceptionOccurred.should.be.true;
exceptionOccurred = false;

try {
program.parse(['node', 'test', '--foo', '-u', 'args1']);
} catch (ex) {
}
exceptionOccurred.should.be.true;
exceptionOccurred = false;

try {
program.parse(['node', 'test', '--foo', '--unknown', 'args1', 'args2']);
} catch (ex) {
}
exceptionOccurred.should.be.true;
exceptionOccurred = false;

process.exit = oldProcessExit;
console.error = oldConsoleError;