Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo: readme example references variables that don't exist #1342

Merged
merged 1 commit into from
Sep 3, 2020
Merged

fix typo: readme example references variables that don't exist #1342

merged 1 commit into from
Sep 3, 2020

Conversation

iliasbhal
Copy link
Contributor

Pull Request

Problem

Found a type in the readme file while looking for documentation.

Solution

Simply fixing a typo in the readme file.

shadowspawn
shadowspawn approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (My mistake when I moved code into action handler.)

abetomo
abetomo approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch. Thanks!

@shadowspawn shadowspawn merged commit 693a40f into tj:develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iliasbhal @abetomo @shadowspawn