Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine back into single CHANGELOG to simplify searches #1656

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

My motivation for splitting up the CHANGELOG in #1115 was largely to reduce the size of the published package. However, the CHANGELOG is no longer included in the package if published using npm 8 or npm 9. Hurrah!

I have found two annoyances with split CHANGELOG

  • it is more complicated searching the CHANGELOGs to see what version a change shipped in
  • splitting out the CHANGELOG when a version drops out of support is a tedious amount of manual work to move the issue and PR references

Solution

Put them back together again!

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 19c8041 into tj:release/9.x Dec 21, 2021
@shadowspawn shadowspawn deleted the feature/recombine-changelog branch December 21, 2021 07:44
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Dec 21, 2021
@shadowspawn shadowspawn added this to the Commander v9.0.0 milestone Dec 21, 2021
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants