Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework example to avoid graphql warnings #1719

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Rework example to avoid graphql warnings #1719

merged 3 commits into from
Apr 19, 2022

Conversation

shadowspawn
Copy link
Collaborator

Update example for command-arguments:

  • remove the stale file showing deprecated extended .description()
  • rework example as graphql complains about logging variable named "password"!

abetomo
abetomo reviewed Apr 18, 2022
View reviewed changes
examples/argument.js Outdated Show resolved Hide resolved
abetomo
abetomo approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit a80b984 into tj:develop Apr 19, 2022
@shadowspawn shadowspawn deleted the feature/fix-graphql-complaints branch April 19, 2022 08:24
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Apr 19, 2022
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadowspawn @abetomo