Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle falsy values in addHelpCommand() properly #1927

Closed
wants to merge 1 commit into from

Conversation

aweebit
Copy link
Contributor

@aweebit aweebit commented Aug 2, 2023

Cherry-picked from #1926 for better separation of concerns.

Problem

Only false is treated as falsy in addHelpCommand().

ChangeLog

Fixed

  • falsy parameter value handling in .addHelpCommand()

@shadowspawn
Copy link
Collaborator

The false check is as intended.

(I would normally leave this open for discussion, but you are have opened ~15 Pull Requests in the last week with ~160 comments between us. I don't have the time to continue that level of feedback.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants