Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sharing and stand-alone parsing of subcommands. Warn about parse calls on commands added with .command() #1938

Closed
wants to merge 21 commits into from
Closed

Add support for sharing and stand-alone parsing of subcommands. Warn about parse calls on commands added with .command() #1938

wants to merge 21 commits into from

Commits on Aug 4, 2023

  1. Add missing checks for passThroughOptions

    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4f5ab2d View commit details
    Browse the repository at this point in the history

  2. Add tests for illegal passThroughOptions

    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0ac6609 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Remove illegal passThroughOptions check deemed unnecessary

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    9d4c96a View commit details
    Browse the repository at this point in the history

  2. Use weaker wording: "broken" instead of "illegal"

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    43d9faa View commit details
    Browse the repository at this point in the history

  3. Unclutter error message in broken passThrough checks 

    Co-authored-by: John Gee <john@ruru.gen.nz>
    @aweebit @shadowspawn
    aweebit and shadowspawn committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    43cc821 View commit details
    Browse the repository at this point in the history

  4. Refactor _checkForBrokenPassThrough() to make it instance-aware

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    7689506 View commit details
    Browse the repository at this point in the history

  5. Add subroutine for common parse call code 

    Borrowed from tj#1917 and tj#1919.
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    d1686db View commit details
    Browse the repository at this point in the history

  6. Add support for sharing and stand-alone parsing of subcommands

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    3de6161 View commit details
    Browse the repository at this point in the history

  7. Warn about parse calls on commands added with .command()

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    680930d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'release/12.x' into feature/parents-with-implicit-subcom… 

    …mand-parse-warning
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    ea728ec View commit details
    Browse the repository at this point in the history

  9. Get rid of redundant currentParent 

    .currentParent is expected to never be different from .parent in
existing code using the library as intended.
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    5085ddc View commit details
    Browse the repository at this point in the history

  10. Introduce _getCommandAndAncestors() 

    Replaces getCommandAndParents():
- turned into an instance method
- used "ancestors" instead of "parents" because it is more specific and
  to avoid confusion with the recently introduced parents array
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    aa280af View commit details
    Browse the repository at this point in the history

  11. Use _getCommandAndAncestors() consistently

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    777a452 View commit details
    Browse the repository at this point in the history

  12. Introduce _getCommandAndAncestors() 

    Replaces getCommandAndParents():
- turned into an instance method
- used "ancestors" instead of "parents" because it is more precise

(cherry picked from commit aa280af)
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    2005522 View commit details
    Browse the repository at this point in the history

  13. Use _getCommandAndAncestors() consistently 

    (cherry picked from commit 777a452)
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    da5a499 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'feature/_getCommandAndAncestors' into feature/parents-w… 

    …ith-implicit-subcommand-parse-warning
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    724d414 View commit details
    Browse the repository at this point in the history

  15. Copy type for parents and JSDoc comment for parent to .d.ts file 

    A corresponding type test for parents has been added.
    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    5828e16 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Use _getCommandAndAncestors() less aggressively 

    Only call when all elements are to be iterated.
Resort to manual iteration via .parent in other cases.
    @aweebit
    aweebit committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8b11122 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Remove NODE_ENV check 

    Motivation: tj#1955
    @aweebit
    aweebit committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f7fd986 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge branch 'feature/_getCommandAndAncestors' into feature/parents-w… 

    …ith-implicit-subcommand-parse-warning
    @aweebit
    aweebit committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    4d2415c View commit details
    Browse the repository at this point in the history

  2. Reword warning about parse calls on commands added with .command() 

    Made it less strict: the library user might know better.
    @aweebit
    aweebit committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    cea6e9d View commit details
    Browse the repository at this point in the history