Fix broken typescript-checkJS script. Store config for the script in jsconfig.json so that it is picked up by VS Code
#1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better consistency with the TSConfig option name. The script had been broken for a long time, so it is safe to assume nobody relies on the old name in custom scripts.
This was referenced Aug 13, 2023
shadowspawn
added
the
on hold
shadowspawn
removed
the
on hold
shadowspawn
added
the
on hold
|
Closing in favor of #1969. |
shadowspawn
removed
the
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #1960 renaming files in such a way that the right TSConfig is picked up by VS Code for live checks that lead to error highlighting.
tsconfig.checkJs.json -> jsconfig.jsonjsconfig.jsontsconfig.json -> tsconfig.base.jsonjsconfig.jsonunder the old name since it would be picked up by VS Code instead.eslint.rc, but maybe that is not necessary and the newtsconfig.jsoncould be used instead