Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #560 respect custom name for version option #753

Merged
merged 1 commit into from Jan 30, 2018
Merged

resolves #560 respect custom name for version option #753

merged 1 commit into from Jan 30, 2018

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@mojavelinux
Copy link
Contributor Author

I'm still working on a test. The version function isn't tested at all from what I can tell, so I'll add a version for both the implicit and custom scenarios.

@mojavelinux
Copy link
Contributor Author

Tests added!

@mojavelinux
Copy link
Contributor Author

I made it clear that the long option is required.

@abetomo abetomo merged commit d5ac793 into tj:master Jan 30, 2018
@mojavelinux
Copy link
Contributor Author

👍

@mojavelinux mojavelinux deleted the issue-560-version-option branch January 30, 2018 03:34
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@roman-vanesyan roman-vanesyan Awaiting requested review from roman-vanesyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojavelinux @abetomo