New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: dont require('redis') if client is passed in (which will allow support for haredis) #56

Closed

nickminutello opened this issue Aug 30, 2012 · 1 comment

nickminutello commented Aug 30, 2012

If you allow the redis client to be passed in, there shouldnt be any need to depend on redis module. Should just require('redis') in a lazy fashion.

ie:

    this.client = options.client || new redis.createClient(options.port || options.socket, options.host, options);

should be

    this.client = options.client || new require('haredis').createClient(options.port || options.socket, options.host, options);

For what its worth : haredis: https://github.com/carlos8f/haredis

Author

nickminutello commented Dec 24, 2012

Any thoughts?

chirag04 closed this as completed in

30d7013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment