Fix loading of all keys for large databases #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since getting a list of keys is asynchronous from getting a value of a single key, there're situations, when key no longer exists in the database, so the script will because of data being null. This fix ensures we skip null values.
|
@patriksimek good catch, thank you! |
jellis24
added a commit
to jellis24/connect-redis
that referenced
this pull request
Apr 6, 2022
Since getting a list of keys is asynchronous from getting a value of a single key, there're situations, when key no longer exists in the database, so the script will because of data being null. This fix ensures we skip null values. PR: tj/connect-redis#299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since getting a list of keys is asynchronous from getting a value of a single key, there're situations, when key no longer exists in the database, so the script will throw because of data being null. This fix ensures we skip null values.