Add support for Promises #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows better integration to Promised based environments
|
@alexsomeoddpilot this looks great! Since you're adding a promise library dependency, I'd prefer to use bluebird. When that's updated, I'll test it out and merge it in. Thanks. |
|
No problem! I've switched to using bluebird with a couple of lines in 8d6a10b and the tests should stay the same. |
|
👍 looks good. |
|
This has been released in |
|
Thanks! I'll work on writing up some usage of the promise API in the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no callback
fnis provided, render functions should return Promises which either resolve to the compiled HTML or an error.No changes are made to the regular API, only the addition of the return value when no callback is provided.