Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all comments being parsed. #149

Closed
trusktr opened this issue Feb 6, 2015 · 8 comments
Closed

Not all comments being parsed. #149

trusktr opened this issue Feb 6, 2015 · 8 comments

Comments

@trusktr
Copy link
Contributor

trusktr commented Feb 6, 2015

parseComments is returning an Array with a length of two for the following file even though it has more than two comments: https://github.com/trusktr/readem/blob/d51f9e899702318526bd7322e10bb1e8fbd671f9/bin/read'em.js

@trusktr
Copy link
Contributor Author

trusktr commented Feb 16, 2015

@trusktr
Copy link
Contributor Author

trusktr commented Feb 16, 2015

Changing the line from

        .option('-t, --template <destination>', 'The template to use. Defaults to readem\'s own template.')

to

        .option('-t, --template <destination>', "The template to use. Defaults to readem's own template.")

also results in the problem.

@trusktr
Copy link
Contributor Author

trusktr commented Feb 16, 2015

Changing the line to

        .option('-t, --template <destination>', 'The template to use. Defaults to the template shipped with readem.')

temporarily solves the problem. :)

@Twipped
Copy link
Collaborator

Twipped commented Mar 18, 2015

@trusktr can you check against the current master and let me know if this is still happening. I suspect this was related to 55d2b92

@sdepold
Copy link

sdepold commented May 14, 2015

This is still an issue

@trusktr
Copy link
Contributor Author

trusktr commented May 14, 2015

When Mixed Mode of Famo.us comes out (very soon) I'll be back to developing my UI components, and documenting them, and hence I'll be back to dox and will check this out. @ChiperSoft I see the context parsers array. Looks good. (:

@Twipped
Copy link
Collaborator

Twipped commented Mar 29, 2016

Version 0.8.1 has been published with @ammojamo's fix for this.

@trusktr
Copy link
Contributor Author

trusktr commented Apr 5, 2016

Sweeeet. I'll be back to this soon. Dropped Famous, and am working on an engine from scratch at http://infamous.io (name subject to change), which I'll need to document eventually. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants