Update git-delete-branch #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming 'origin' as the remote, default to using the remote tracking configuration. This can be overridden by using the -r option to provide a remote name and a remote branch name. This also removes the ability to delete multiple branches at once. Closes tj#514.
|
LGTM |
| case "$opt" in | ||
| r) | ||
| remote="$(echo ${OPTARG} | cut -d ':' -f 1)" | ||
| remote_branch="$(echo ${OPTARG} | cut -s -d ':' -f 2)" |
There was a problem hiding this comment.
Better to use parameter expansion instead.
There was a problem hiding this comment.
Better to use parameter expansion instead.
Hmm I thought using cut would be more clear. So is this what you're suggestion:
So instead of:
remote="$(echo ${OPTARG} | cut -d ':' -f 1)"
remote_branch="$(echo ${OPTARG} | cut -s -d ':' -f 2)"you want:
remote=${OPTARG%%:*}
remote_branch=${OPTARG##*:}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming 'origin' as the remote, default to using the remote
tracking configuration. This can be overridden by using the
-roption toprovide a remote name and a remote branch name. This also removes the ability
to delete multiple branches at once.
Closes #514.
@hemanth, apologies this took so long. I haven't updated the completions file yet,
need to figure that out.
Thoughts?