Removed xargs from git-effort #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way to solve issue #953, but it's a little bit flawed.
The problem is that we used
xargs --max-args 1 --replace % -c bash "effort \"%\"", because the functioneffortonly takes one argument and we want it to be quoted.--max-argsand--replaceare conflicting in newer versions of xargs.In this PR I've removed xargs and only use bash code to call
effort. However, the previous implementation used the--max-procs=4option to xargs to useeffortin four "threads". This version forks heavily, which could cause performance problems in the rest of the system.I have only done some minor tests in one repo, it should be tested in more repos and on other OS:es as well.