Add support for +v2 modules

[wallyqs]

This adds support to Go packages that have versions above v2. Similar to go get the /v2 major version has to be declared when making the package build request:

Usage:

# Explicit +v2 version
curl -sf 'http://localhost:3000/nats-io/nats-server@v2.1.6' | PREFIX=. sh

# Resolved version gets v2 from master
curl -sf 'http://localhost:3000/nats-io/nats-server' | PREFIX=. sh

# Explicit v1 version
curl -sf 'http://localhost:3000/nats-io/nats-server@v1.4.1' | PREFIX=. sh

# v2 nested modules too 🎉 
curl -sf 'http://localhost:3000/caddyserver/caddy/cmd/caddy' | PREFIX=. sh

If the major version is not specified in the path, similar to go get and go modules, it will fallback to the v1 version of the package (even if the actual latest version is higher).

curl --output - 'http://127.0.0.1:3000/binary/github.com/nats-io/nats-server?os=darwin&arch=amd64&version=v2.1.6' > my-nats-v1
./my-nats-v1 
[98946] 2020/05/07 16:54:40.726190 [INF] Starting nats-server version 1.4.1

Fixes #10

Signed-off-by: Waldemar Quevedo wally@synadia.com

[tj]

Feel like I'm going crazy hahah it's still not working for me:

curl -sf http://localhost:3000/nats-io/nats-server/v2 | PREFIX=. sh

  ==> Downloading github.com/nats-io/nats-server/v2@master
  ==> Resolved version master to v2.1.6
  ==> Downloading binary for darwin amd64
  ==> Installing v2 to .
  ==> Installation complete

   λ test: ./nats-server --version
nats-server version 1.4.1

maybe just an ldflags issue setting the version? I tried curl -sf http://localhost:3000/nats-io/nats-server | PREFIX=. sh as well

[wallyqs]

The issue is that the binary name is becoming v2... in this case...

curl -sf 'http://localhost:3000/nats-io/nats-server/v2' | PREFIX=. sh

  ==> Downloading github.com/nats-io/nats-server/v2@master
  ==> Resolved version master to v2.1.6
  ==> Downloading binary for darwin amd64
  ==> Installing v2 to .
  ==> Installation complete

./v2
[15776] 2020/05/12 14:48:56.714517 [INF] Starting nats-server version 2.1.6
[15776] 2020/05/12 14:48:56.714687 [INF] Git commit [not set]
[15776] 2020/05/12 14:48:56.715021 [INF] Listening for client connections on 0.0.0.0:4222
[15776] 2020/05/12 14:48:56.715032 [INF] Server id is NCVRTCKFBORWDJ3IWTRGRMKV3ZFANVJZH5Z5EW34EQ34HAXV7TEP2QOG
[15776] 2020/05/12 14:48:56.715038 [INF] Server is ready
^C[15776] 2020/05/12 14:48:58.492238 [INF] Initiating Shutdown...
[15776] 2020/05/12 14:48:58.492495 [INF] Server Exiting..

[wallyqs]

Pushed a few commits to fix the issue with the resulting binary name being v2. There are still a few corner cases but when the version is explicit like this it should work now (only on repos when main is at the root)

curl -sf 'http://localhost:3000/nats-io/nats-server@v2.1.6' | PREFIX=. sh

[wallyqs]

@tj found out how to use the resolved version, so now all of these should work:

# Explicit +v2 version
curl -sf 'http://localhost:3000/nats-io/nats-server@v2.1.6' | PREFIX=. sh

# Resolved version gets v2 from master
curl -sf 'http://localhost:3000/nats-io/nats-server' | PREFIX=. sh

# Explicit v1 version
curl -sf 'http://localhost:3000/nats-io/nats-server@v1.4.1' | PREFIX=. sh

Still not working are the nested modules that have v2 since have to figure out where to insert the version between the nested module and the module name like caddyserver/caddy/${v2}/cmd@v2.0.0. For now, changed the scope of the PR to get modules that have main at the root first (non-nested).

[tj]

I imagine few people will use gobinaries unless they found the one-liner in a Readme, so maybe it's ok to assume the author should insert the /v2/? Kinda ugly, or we could maybe assume /<owner>/<repo> for the moment since it's locked into GH anyway

[wallyqs]

assuming first <owner>/<repo> for the moment sounds good, will make an update

[wallyqs]

Actually still haven't been able to figure out how to build Go mod enabled repos with v2 that use nested repositories like caddy... will continue to leave the scope of this PR to support repos that have main at the root for now....

[wallyqs]

Wait I got it working! 🎉 Ok Go v2 modules should be supported now. Happy Friday 😃

curl -sf 'http://localhost:3000/caddyserver/caddy/cmd/caddy' | PREFIX=. sh
./caddy version
v2.0.0 h1:pQSaIJGFluFvu8KDGDODV8u4/QRED/OPyIR+MWYYse8=

[tj]

wahoooo 🎉 I'll try and check it out soon!

[tj]

Forgot to try it this weekend, I'll try to get to it tonight and deploy!

[tj]

sweet looks good, I'll get it deployed. Thanks man!

We could probably refactor a bit later with https://github.com/tj/go-semver to parse the version since I already have that dep pulled in, but not a big deal either way

[tj]

deployed!

[wallyqs]

Thanks @tj !!