Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copy README/LICENSE/Changelog to /user/local #179

Merged
merged 1 commit into from Jun 28, 2014
Merged

Conversation

hax
Copy link
Contributor

@hax hax commented Jun 10, 2014

fix #158

@tjwebb
Copy link
Collaborator

tjwebb commented Jun 10, 2014

Looks good. @stanzheng would you mind taking a look at this on mac?

@qwo
Copy link

qwo commented Jun 11, 2014

Not too familiar with what the issue is, I pulled down the changes and ran some commands.
Everything looks as expected behaviors, no conflicts. The README in /usr/local/ is still installed but no conflicts are created.

╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ ls
n
╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ sudo n prev

    activate : 0.10.28

╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ sudo n latest
╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ node -v
v0.11.13
╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ cat /usr/local/README.md
Evented I/O for V8 javascript.
===

### To build:

@tjwebb
Copy link
Collaborator

tjwebb commented Jun 11, 2014

@stanzheng the README shouldn't be there on a clean install. It apparently screws up homebrew (#158)

@qwo
Copy link

qwo commented Jun 11, 2014

I mean I ran these series of commands. It still installs the README on each edit. Why not add something that just nerfs the readme after install?

OSX 10.9 Mavericks* ZSH

─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ ls
n
╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ rm /usr/local/README.md
╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ cat /usr/local/README.md
cat: /usr/local/README.md: No such file or directory
╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ sudo n prev                                                                                                                                                                  1 ↵
Password:

    activate : 0.10.28

╭─stanzheng@stanzheng-2  ~/code/oss/n/bin  ‹master›
╰─$ cat /usr/local/README.md
Evented I/O for V8 javascript. [![Build Status](https://secure.travis-ci.org/joyent/node.png)](http://travis-ci.org/joyent/node)
===

@tjwebb
Copy link
Collaborator

tjwebb commented Jun 11, 2014

Are you really on master? The code hasn't been merged...

@qwo
Copy link

qwo commented Jun 11, 2014

i merged locally

*   24b2f78 - (HEAD, master) Merge branch 'hax-patch-1' (64 minutes ago) <stanzheng>
|\
| * ef53055 - (hax-patch-1) Avoid copy README/LICENSE/Changelog to /user/local (6 hours ago) <HE Shi-Jun>
|/
*   69c16e4 - (origin/master, origin/HEAD) Merge pull request #126 from hstkk/which (6 days ago) <Travis Webb>

@tjwebb
Copy link
Collaborator

tjwebb commented Jun 11, 2014

Weird. Ok thanks dude.

tjwebb pushed a commit that referenced this pull request Jun 28, 2014
Avoid copy README/LICENSE/Changelog to /user/local
@tjwebb tjwebb merged commit 9b03a52 into tj:master Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n places README.md inside /usr/local, causing brew update to fail
3 participants