Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for arm64. #448

Merged
merged 1 commit into from Mar 29, 2019
Merged

Added support for arm64. #448

merged 1 commit into from Mar 29, 2019

Conversation

joeledwards
Copy link
Contributor

I added support for the arm64 architecture.

This is already made available on nodejs.org. In the archives it is identified as arm64. I have seen it identified on systems as both arm64 and aarch64, so both are mapped to arm64 in my update.

@krzysdz krzysdz mentioned this pull request Jun 6, 2018
Closed
@tlvince
Copy link

tlvince commented Jun 8, 2018

@troy0820 / other contributors, sorry for the +1 comment, but could this get merged in? It's nearly a year old, but will merge cleanly and is very useful for ARM machines. See also #494 and #507. Thanks!

@shadowspawn
Copy link
Collaborator

For reference, question and explanation why both arm64 and aarch64
https://stackoverflow.com/questions/31851611/differences-between-arm64-and-aarch64

@joeledwards joeledwards mentioned this pull request Jul 26, 2018
Closed
shadowspawn
shadowspawn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. (I am not a maintainer.)

farmio
farmio approved these changes Nov 28, 2018
View reviewed changes
Copy link

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me.

@athisun athisun mentioned this pull request Feb 17, 2019
Closed
@MichaIng
Copy link

MichaIng commented Feb 17, 2019 •
edited

Simple, clean and jep required on ARMv8 systems to run n without adding explicit -a option. Currently it attempts to install the amd64 version otherwise, which of course fails.

Please merge this to avoid further user reports/complains.

@MichaIng MichaIng mentioned this pull request Feb 17, 2019
Merged
1 task
This was referenced Feb 22, 2019
Closed
Merged
@shadowspawn
Copy link
Collaborator

shadowspawn commented Feb 28, 2019 •
edited

(If a fork of n is an option to readers with this problem, I added aarch64 and arm64 support to https://github.com/shadowspawn/nvh prompted by this issue, and willing to make changes if not working as intended. Note: nvh requires rsync.)

@shadowspawn shadowspawn self-assigned this Mar 23, 2019
@shadowspawn
Copy link
Collaborator

Aiming to have this released within a week. Manually merged into develop branch preparing for release. See #559

@shadowspawn shadowspawn merged commit 160613c into tj:master Mar 29, 2019
@shadowspawn
Copy link
Collaborator

Released in v3.0.0

@MichaIng MichaIng mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmio farmio farmio approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees

@shadowspawn shadowspawn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joeledwards @tlvince @shadowspawn @MichaIng @farmio