Fail for blank target from auto (or engine) version file #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Using
auto
andengine
will fallback tocurrent
if the found version file does not contain a target version. This could be due to an empty version file, but the more likely situation is apackage.json
with noengines
field. This is a bit surprising and not particularly useful.There is a technical argument for
current
if there is anengines
field with anode
field which is empty, but even then installing the current version of node is not all that useful.https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines
Resolves: #692
Solution
Display an error if the target version is missing (blank).
ChangeLog
auto
andengine
(rather than fallback tocurrent
)